On Tue, Aug 06, 2002 at 02:47:07PM -0500, Karl Fogel wrote:
>...
> Two recent patches have revealed that we may need to change where we
> define the version of Subversion.
>
> Currently, the "master" location is svn_version.h, where we define the
> SVN_VER_MAJOR, SVN_VER_MINOR, and SVN_VER_MICRO constants.
>
> Then Art Haas posted a patch that would have duplicated this
> information in configure.in. Meanwhile, Scott Lamb posted a patch
> which hints that we (I *think*) are essentially duplicating the
> SVN_VER_MAJOR constant in build.conf... Only it's out of sync right
> now, claiming 1 instead of 0 :-). Greg Stein may clarify this, but
> for now I'll assume that the situation is as I've just described it.
The library version will *probably* match the major version since we use
major version to indicate binary compatibility, which is what the lib
version also does. I'm just not entirely positive, though, so it is probably
best to keep the two numbers independent.
It should be quite easy for us to extract the lib version from a header file
(which would make it available to svn_ra.h for dynloading).
> So:
>
> I'm wondering if svn_version.h is really the right place to define
> these. If we did it in configure.in, then Art could use it, and it
> would be easy to pass the same version information down to both
> build.conf (which would become build.conf.in) and svn_version.h
> (becomes svn.version.h.in).
No can do. Windows does not use configure(.in), so you would end up defining
the version number in configure.in *and* svn_private_config.hw.
svn_version.h is the right place... that's why I put it there :-)
> Whatever we do, I think it's important that there be exactly *one*
> place where its defined. If svn_version.h can be that place, and
> everyone else just deduces it from there, that's fine. I'm just
> guessing that it would be easier if it were configure.in.
Agreed on the "one place". I think we probably want to introduce
SVN_VER_LIBRARY to contain the library version. We can then extract that for
use in the Makefile for building libs.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 6 22:54:12 2002