[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2892 - trunk/subversion/mod_dav_svn

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2002-08-06 16:59:09 CEST

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> sussman@tigris.org writes:
> > New <Location> command for mod_dav_svn: SVNParentPath. Allows you to
> > specify a location as the *parent* directory of any number of implicit
> > svn repositories. The name of each svn repository is assumed to be
> > the component immediately after the Location.
> >
> > So for example:
> >
> > <Location /svn>
> > DAV svn
> > SVNParentPath /usr/local/svn
> > </Location>
> >
> > This means I could now run 'svnadmin create /usr/local/svn/moorepo',
> > and then 'svn co http://localhost/svn/moorepo' would work
> > automatically, *without* changing httpd.conf or restarting apache.
>
> Maybe this portion of your log message could go in a comment in the
> code, or even better into the documentation?
>
> The HACKING file says it best, so I'll just quote:
>
> One should never need the log entries to understand the current
> code. If you find yourself writing a significant explanation in
> the log, you should consider carefully whether your text doesn't
> actually belong in a comment, alongside the code it explains.

Oops, you're right, sorry for being so verbose.

I often get annoyed when I see a log message that has nothing but a
list of file/symbol change descriptions, and is missing a "one
sentence summary" at the top. I want to know the general intent of
the patch *before* reading about particular changes to symbols.

But my great weakness is to go too far in the other direction. My
one-sentence summary ends up being an essay. :-(

There's no need to put my log msg in the code. The code is obvious.
My verbiage is nothing but a feature description, better moved to the
Handbook... which I'll do.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 6 17:00:48 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.