Re: svn commit: rev 2890 - trunk/subversion/clients/cmdline

brane@tigris.org wrote:
>
> Author: brane
> Date: 2002-08-05 17:34:28 -0500 (Mon, 05 Aug 2002)
> New Revision: 2890
>
> Modified:
> trunk/subversion/clients/cmdline/help-cmd.c
> trunk/subversion/clients/cmdline/main.c
> Log:
> Make "svn --version --quiet" print only the version number.
>
> * subversion/clients/cmdline/main.c (svn_cl__cmd_table): Allow option
> --quiet with "svn help".
> * subversion/clients/cmdline/help-cmd.c (print_version_info): When the
> new parameter 'quiet' is true, print only SVN_VER_NUMBER and return.
> (svn_cl__help): Pass opt_state->quiet to print_version_info, and
> fixx typo in comment: -v is no longer a shorthand for --verbose.

I think this change broke the getopt_tests.py part of make check:

% python2 ./getopt_tests.py 5
Standard output does not match.
Expected standard output:
['help (?, h): Display this usage message.\n', 'usage: svn help
[SUBCOMMAND1 [SUBCOMMAND2] ...]\n', '\n', 'Valid options:\n',
' --version : print client version info\n', '\n']

Actual standard output:
['help (?, h): Display this usage message.\n', 'usage: svn help
[SUBCOMMAND1 [SUBCOMMAND2] ...]\n', '\n', 'Valid options:\n',
' --version : print client version info\n',
' -q [--quiet] : print as little as possible\n', '\n']

FAIL: getopt_tests.py 5: run svn help --version

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org