[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Add svn_wc_status_obstructed

From: Sander Striker <striker_at_apache.org>
Date: 2002-08-05 22:06:12 CEST

> From: brane@xbc.nu [mailto:brane@xbc.nu]
> Sent: 05 August 2002 21:42

> Sander Striker wrote:
>> This patch adds a new status code to subversion: svn_wc_status_obstructed.
>> An entry gets this status when:
>> a) the entry's kind is different from the filesystem
>> b) the entry should be a versioned directory, but the directory
>> doesn't appear to be so on the filesystem.
>> This scratches an itch for me when it comes to writing gui code.
>> svn_wc_statuses returns an error on case b), instead of continueing
>> and filling in the status codes for all the entries in the
>> working copy directory I'm inquiring about.
>> Thinking about it, the patch is incomplete, I'm not paying attention
>> the the STRICT argument.
>> Thoughts?
> 18 columns of nesting is way to deep. Oh, you wanted some constructive
> thoughts? :-)

> Just one thing: Why restrict this to the cases you mentioned above,
> instead of "simply" implementing what the comment beside the new enum
> constant says? I think it's clear enough.

The cases I mentioned above is the entire set of cases that make up
the comment beside the new enum constant. That is, if I am correct ;)

> Then again, maybe I misunderstood both the patch and your explanation...


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 5 21:56:50 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.