Re: svn commit: rev 2821 - trunk/subversion/libsvn_wc trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline

Greg Stein <gstein@lyra.org> writes:

> > > OK, so libsvn_wc can assume its paths are canonical, what about other
> > > layers? Where should the canonicalization occur, in the application?
> > > In libsvn_client? At the libsvn_wc interface?
> >
> > I think that canonicalization should fall at the same line as
> > case-correctness and UTF-8 conversion and URI-encoding ... it is the
> > job of the client binary to supply such to libsvn_client (and
> > libsvn_whatever as the case may be).
>
> IMO, the canonical form for a directory should include a trailing slash. Or
> at least we should generate URLs like that. If not, then Apache is going to
> send us a redirection and we'll have to re-issue a request (suck).

It may well make sense for URLs sent over ra_dav, but I'm not sure
that it makes sense for the client and wc interfaces. It requires us
to know whether things are files or directories.

svn_client_add(... const char *path ...)
svn_wc_add(... const char *path ...)
svn_client_commit(... const char *path ...)

Will the caller of these be required to know whether path is a file or
a directory? What about scheduled for deletion items that are not
physically present?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org