Re: Applying entries cache patch?

Justin Erenkrantz <jerenkrantz@apache.org> writes:

> My plan is to integrate the targeted patch that I posted a while
> back that only partially passes the baton around. That should
> speed up the diff and commit process. Then, I plan on working
> my way through libsvn_wc and adding the baton to all functions
> that read the entries file. I don't expect to break anything,
> but it could happen. =) -- justin

As I recall that patch introduced a cached interface parallel to the
current non-cached interface. I still think that's tricky to get
right, how do you ensure that there is not a code path that bypasses
the cached interface and call the non-cached one? I think the correct
approach is to put the baton in place first, then replace the
non-cached interface with the cached one.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org