[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2821 - trunk/subversion/libsvn_wc trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-08-01 21:04:59 CEST

Philip Martin <philip@codematters.co.uk> writes:
> In this case the failure was "svn ci" with no explicit target, the
> locking code is given a path with a trailing slash.
> When I started the access baton stuff, and started storing/comparing
> paths I immediately had problems like this. Most of the libsvn_wc
> code doesn't appear to care whether paths are canonical, so my guess
> is that non-canonical paths get in.

So if "canonical" means "has a trailing slash" (which I'm not sure it
does, but that's a different question), then the real fix is to fix
the callers of libsvn_wc, not to start patching up libsvn_wc to accept
less-than-canonical patches...

If you want to detect them and *error*, that's fine. But I think
silently papering over them is a mistake. We need to discipline the


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 1 21:19:53 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.