Re: svnlook fails as subprocess, but succeeds when run directly?

Karl Fogel wrote:
> In the longer term, I think we should just inherit the environment
> in the hook subprocesses. Can anyone see any disadvantage or risk
> to doing so?

Kind of.

In the case of Apache and mod_dav_svn, no - except that sometimes it
would probably be easier to have a better way of setting the
environment than just mucking about with the parent environment.

But in the case of ra_local, this sounds a bit bad - since if there's
a script that uses svnlook there, then it means that it may depends on
the user committing that how the output looks like.

I think care should be had in trying to invoke the hook script in an
exactly similar manner regardless of who or from where it is invoked
from. On the other hand, it seems like a very good practice to try and
make the hook script itself behave the same, regardless of how it is
started.

In any case, just pointing it out, if no-one thought of this.

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 29 20:18:20 2002