[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnlook fails as subprocess, but succeeds when run directly?

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-26 16:22:51 CEST

brane@xbc.nu writes:
> Maybe because we don't call the hooks with APR_PROGRAM_ENV, so they don't get
> the real LC_CTYPE, and the default one is "C", so that the
> setlocale(LC_CTYPE, "") call in svnlook/main.c is actually a no-op?
>
> Just guessing ...

Yup, that was the problem. We don't pass the environment when we run
the hooks, so LC_CTYPE, LANG, whatever, are not set for the hook
scripts.

As a workaround, I've temporarily set

   LANG=en_US

in the live pre-commit and post-commit scripts on svn.collab.net. As
you can see from revision 2734, that solved the problem :-).

In the longer term, I think we should just inherit the environment in
the hook subprocesses. Can anyone see any disadvantage or risk to
doing so?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 26 16:36:41 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.