Re: [PATCH] svn-config

Justin Erenkrantz wrote:
> On Mon, Jul 29, 2002 at 11:08:54AM -0500, Scott Lamb wrote:
>
>>Fix svn-config to generate library options for external apr, aprutil, and
>>neon. Still doesn't link against Subversion itself.
>

[first bit quoted later]

>>* ac-helpers/neon.m4:
>> Substitute $abs_(src|build)dir in configure, as Makefile and svn-config have
>> different variable expansion rules.
>
>
> Ditto. The issue is to have the abs_srcdir/abs_builddir variables
> available in svn-config itself.

They are. The problem is that LIBS uses this syntax:

     $(abs_srcdir)/blah

which works in make, but /bin/sh won't understand it at all and
/bin/bash will treat it as a shell expansion. And of course make doesn't
understand sh's syntax. So it was either expand it in configure (which I
don't see any disadvantage to - abs_srcdir is only changed at
configure-time anyway) or do some silly sed thing in svn-config.

> The trick with --link-libtool is that you can specify just the
> SVN libraries and all of the other libraries are dragged in. (i.e.
> you don't need to add the dependencies yourself).

Okay, didn't realize libtool was that smart.

>>* ac-helpers/aprutil.m4, ac-helpers/apr.m4:
>> Renamed SVN_APRUTIL_EXPORT_LIBS to SVN_APRUTIL_LD_LIBS.
>> (SVN_APRUTIL_LIBS is also used for export with "svn-config
--link-libtool")
>
> There's no need to change the variable name here.

This makes sense after your comments about libtool. I thought the name
was deceptive because SVN_APRUTIL_LIBS was also necessary for export,
but it is not.

--
Scott Lamb
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org