[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] RapidSVN first impressions, and a small fix

From: Alexander Mueller <alex_at_littleblue.de>
Date: 2002-07-26 14:46:08 CEST

Tried to apply your patch. Resulted some errors:
$ patch -i p
patching file `tracer.cpp'
Hunk #2 FAILED at 59.
1 out of 2 hunks FAILED -- saving rejects to tracer.cpp.rej
patching file `tracer.h'
patching file `exceptions.cpp'
Hunk #2 FAILED at 25.
1 out of 2 hunks FAILED -- saving rejects to exceptions.cpp.rej
patching file `exceptions.h'
Hunk #2 FAILED at 33.
1 out of 2 hunks FAILED -- saving rejects to exceptions.h.rej

could you check this?

Garrett Rooney wrote:

>On Thu, Jul 25, 2002 at 09:29:05PM -0400, Garrett Rooney wrote:
>
>
>>so i just played around with RapidSVN a bit, and it looks pretty neat.
>>
>>
>
>ok, here's a patch to clean up a few warnings from g++ -Wall. (just
>'you have a class with virtual functions and no virtual destructor'
>stuff, there are a lot of other warnings about unused variables and
>stuff, but i imagine those are for work that isn't complete yet.
>
>
>Index: ./tracer.cpp
>===================================================================
>--- ./tracer.cpp
>+++ ./tracer.cpp Thu Jul 25 21:57:10 2002
>@@ -36,6 +36,10 @@
> {
> }
>
>+ErrorTracer::~ErrorTracer()
>+{
>+}
>+
> void ErrorTracer::Trace( const wxString& str )
> {
> msgs += str + _T("\n");
>@@ -55,4 +59,4 @@
> void StringTracer::Trace( const wxString& str )
> {
> msgs += str + _T("\n");
>-}
>+}
>Index: ./tracer.h
>===================================================================
>--- ./tracer.h
>+++ ./tracer.h Thu Jul 25 21:54:47 2002
>@@ -58,6 +58,9 @@
>
> public:
> ErrorTracer( wxWindow *__parent );
>+
>+ virtual ~ErrorTracer();
>+
> void Trace( const wxString& );
> void ShowErrors();
> };
>Index: ./exceptions.cpp
>===================================================================
>--- ./exceptions.cpp
>+++ ./exceptions.cpp Thu Jul 25 21:53:46 2002
>@@ -7,6 +7,10 @@
> what( __estr );
> }
>
>+VSvnEx::~VSvnEx()
>+{
>+}
>+
> VSvnEx& VSvnEx::operator=( const VSvnEx& rhs )
> {
> if( this == &rhs )
>@@ -21,4 +25,4 @@
> void VSvnEx::what( const wxString& __what )
> {
> estr.Printf( _T("%s code: %ld"), __what.c_str(), code );
>-}
>+}
>Index: ./exceptions.h
>===================================================================
>--- ./exceptions.h
>+++ ./exceptions.h Thu Jul 25 21:55:09 2002
>@@ -11,6 +11,8 @@
> VSvnEx( const wxString&__estr = "",
> const long __code = -1 );
>
>+ virtual ~VSvnEx();
>+
> VSvnEx( const VSvnEx& rhs )
> {
> *this = rhs;
>@@ -31,4 +33,4 @@
> return estr;
> }
> };
>-#endif
>+#endif
>
>
>
Received on Fri Jul 26 14:46:59 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.