Re: [PATCH] RapidSVN first impressions, and a small fix

On Thu, Jul 25, 2002 at 09:29:05PM -0400, Garrett Rooney wrote:
> so i just played around with RapidSVN a bit, and it looks pretty neat.

ok, here's a patch to clean up a few warnings from g++ -Wall. (just
'you have a class with virtual functions and no virtual destructor'
stuff, there are a lot of other warnings about unused variables and
stuff, but i imagine those are for work that isn't complete yet.

Index: ./tracer.cpp
===================================================================
--- ./tracer.cpp
+++ ./tracer.cpp Thu Jul 25 21:57:10 2002
@@ -36,6 +36,10 @@
 {
 }
 
+ErrorTracer::~ErrorTracer()
+{
+}
+
 void ErrorTracer::Trace( const wxString& str )
 {
         msgs += str + _T("\n");
@@ -55,4 +59,4 @@
 void StringTracer::Trace( const wxString& str )
 {
         msgs += str + _T("\n");
-}
+}
Index: ./tracer.h
===================================================================
--- ./tracer.h
+++ ./tracer.h Thu Jul 25 21:54:47 2002
@@ -58,6 +58,9 @@
 
 public:
                                 ErrorTracer( wxWindow *__parent );
+
+ virtual ~ErrorTracer();
+
         void Trace( const wxString& );
         void ShowErrors();
 };
Index: ./exceptions.cpp
===================================================================
--- ./exceptions.cpp
+++ ./exceptions.cpp Thu Jul 25 21:53:46 2002
@@ -7,6 +7,10 @@
         what( __estr );
 }
 
+VSvnEx::~VSvnEx()
+{
+}
+
 VSvnEx& VSvnEx::operator=( const VSvnEx& rhs )
 {
         if( this == &rhs )
@@ -21,4 +25,4 @@
 void VSvnEx::what( const wxString& __what )
 {
         estr.Printf( _T("%s code: %ld"), __what.c_str(), code );
-}
+}
Index: ./exceptions.h
===================================================================
--- ./exceptions.h
+++ ./exceptions.h Thu Jul 25 21:55:09 2002
@@ -11,6 +11,8 @@
                                         VSvnEx( const wxString&__estr = "",
                                                         const long __code = -1 );
 
+ virtual ~VSvnEx();
+
                                         VSvnEx( const VSvnEx& rhs )
                                         {
                                                 *this = rhs;
@@ -31,4 +33,4 @@
                                                 return estr;
                                         }
 };
-#endif
+#endif

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org