[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: how to respond to bad options

From: Jim Blandy <jimb_at_red-bean.com>
Date: 2002-07-26 00:46:41 CEST

"B. W. Fitzpatrick" <fitz@red-bean.com> writes:
> I *totally* agree with this Jim, but I've never been annoyed enough by
> it to bring it up--or submit a patch. I'm +1 on this change of
> behavior.

Now, this patch also changes the behavior of just typing `svn',
nothing else --- now that prints the "type `svn help', you slob"
message. Should `svn' always give the generic help message? I think
the below is okay, but I don't feel strongly about it.

(This is real show-stopper stuff; gotta get it just right, you know.)

2002-07-25 Jim Blandy <jimb@redhat.com>

        * subversion/clients/cmdline/help-cmd.c (svn_cl__help): If the
        user gives an unrecognized command or option, just tell them
        how to get help; don't print the whole list of commands.

Index: ./subversion/clients/cmdline/help-cmd.c
--- ./subversion/clients/cmdline/help-cmd.c
+++ ./subversion/clients/cmdline/help-cmd.c Thu Jul 25 17:37:59 2002
@@ -93,7 +93,7 @@
   else if (os && !targets->nelts) /* `-h', `--help', or `help' */
     svn_cl__print_generic_help (pool, stdout);
   else /* unknown option or cmd */
- svn_cl__print_generic_help (pool, stderr);
+ fprintf (stderr, "Type `svn help' for help on Subversion usage.\n");
   return SVN_NO_ERROR;

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 26 00:47:13 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.