Re: svn commit: rev 2682 - trunk/subversion/mod_dav_svn

On Wed, Jul 24, 2002 at 02:22:49PM -0500, sussman@tigris.org wrote:
>....
> +++ trunk/subversion/mod_dav_svn/activity.c Wed Jul 24 14:22:47 2002
> @@ -88,8 +88,12 @@
> APR_OS_DEFAULT, repos->pool);
> if (status != APR_SUCCESS)
> {
> - /* ### return an error */
> - return NULL;
> + svn_error_t *serr =
> + svn_error_create(status, 0, NULL, repos->pool,
> + "failed to open activity db; check repos perms.");
> +
> + return dav_svn_convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
> + "could not open dbm files.");

Rather than create an svn_error and convert it, how about just using
dav_new_error(_tag) to start with?

>...
> + svn_error_t *serr =
> + svn_error_create(status, 0, NULL, repos->pool,
> + "failed to close activity db; check repos perms.");
> +
> + return dav_svn_convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
> + "could not close dbm files.");

And here.

CHeers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org