Re: svn commit: rev 2684 - trunk/subversion/include trunk/subversion/mod_dav_svn trunk/subversion/clients/cmdline trunk/subversion/libsvn_repos trunk/subversion/libsvn_ra_dav

I hope you can clear up this one detail.

cmpilato@tigris.org wrote:
> * subversion/libsvn_repos/log.c
> (detect_changed): Use 'M' for modify, not 'U'. Use new
> svn_log_changed_path_t structures in the returned hash, and
> check for copy history on adds and replaces.

Ookay.

> * subversion/clients/cmdline/log-cmd.c
> (log_message_receiver): Print copyfrom info returned from `svn
> log'.

Good. But you didn't change log_message_receiver_xml - that's OK
too, no-one else remembers either. I'll do it.

> SVN_ERR (svn_utf_cstring_from_utf8 (&path_native, path, pool));
> - printf (" %c %s\n", action, path_native);
> + printf (" %c %s%s\n",
> + (log_item->action == 'M') ? 'U' : log_item->action,
> + path_native, copy_data);
> }

But I don't get this? Why do we hide 'M' as an action, and instead show 'U'?

Should the XML output have the same action letter as well?

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 24 23:49:35 2002