[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2640 - trunk/subversion/mod_dav_svn

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-24 02:07:02 CEST

Greg Stein <gstein@lyra.org> writes:
> But mostly, I write the review so the person who made the change in question
> (and others) can get an explanation or rationale for the problem. Or to
> alert that person to some facet of the code which they may not have known
> (such as this case; I suspect Ben may not have known about APR_OFF_T_AMT).
> By directly alerting somebody to the problem, then they will (hopefully) not
> repeat it in the future.

+1

And let it be clear that in this case Ben saw and understood the fix,
just didn't want to distract himself by switching tasks.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 24 02:20:04 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.