[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2640 - trunk/subversion/mod_dav_svn

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-07-24 02:12:39 CEST

On Tue, Jul 23, 2002 at 10:04:42AM -0500, kfogel@tigris.org wrote:
> Author: kfogel
> Date: Tue, 23 Jul 2002 10:04:35 -0500
> New Revision: 2640
> Modified:
> trunk/subversion/mod_dav_svn/liveprops.c
> Log:
> Incorporate Greg Stein's review of revision 2637 (saving time for Ben,
> who's working on the Handbook):
> * subversion/mod_dav_svn/liveprops.c
> (dav_svn_insert_prop): Use APR_OFF_T_FMT.

In case anybody wonders, "why the heck didn't Greg just fix that himself?"
Occasionally, I'll do that for short, obvious bloopers where it would take
longer to write an email than to make the fix.

However, if I don't have an up to date copy of the source (and all the
dependencies!), then certain changes can be risky (not this one, but in

But mostly, I write the review so the person who made the change in question
(and others) can get an explanation or rationale for the problem. Or to
alert that person to some facet of the code which they may not have known
(such as this case; I suspect Ben may not have known about APR_OFF_T_AMT).
By directly alerting somebody to the problem, then they will (hopefully) not
repeat it in the future.

Further, if somebody else is changing some code, then they are probably
more familiar with that code, so they should take my feedback in mind and
make the Right Change.

And lastly, but not least important, by emailing a review, it gives the
original author a chance to tell me I'm full of crap, to refine my
suggestions, or any number of problems where my thinking is just wrong.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 24 02:10:23 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.