Re: [PATCH] mod_dav_svn directory listing i18n fix, and odd bug

cmpilato@collab.net wrote:

>Marcus Comstedt <marcus@mc.pp.se> writes:
>
>>Ok, my DAV i18n testing has begun, and so far mostly so good. The
>>directory listing generated when browsing the repository with a web
>>browser fails to set a charset, though. Since the default charset for
>>HTML is ISO-8859-1, filenames do not get displayed correctly. This
>>patch fixes the problem:
>>
>>Index: ./subversion/mod_dav_svn/repos.c
>>===================================================================
>>--- ./subversion/mod_dav_svn/repos.c
>>+++ ./subversion/mod_dav_svn/repos.c Mon Jul 22 19:24:31 2002
>>@@ -1354,7 +1354,7 @@
>> if (resource->info->repos->xslt_uri)
>> mimetype = "text/xml";
>> else
>>- mimetype = "text/html";
>>+ mimetype = "text/html; charset=UTF-8";
>> }
>> else if (resource->info->delta_base != NULL)
>> {
>>
>>
>
>Beautiful!
>
>

Yes, except that we also have to add Content-Transfer-Encoding: 8-bit,
or whatever the header is. I'd vote to add both to the xml case, too,
just to be on the safe side.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org