[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: EINVAL vs APR_EINVAL in apr_xlate_open()

From: Ryan Bloom <rbb_at_covalent.net>
Date: 2002-07-22 04:59:05 CEST

> From: Karl Fogel [mailto:kfogel@newton.ch.collab.net]
> Justin Erenkrantz <jerenkrantz@apache.org> writes:
> > In APR calls, if EINVAL is produced, it should use APR_EINVAL.
> >
> > And, for checking for error, the caller should use
> > APR_STATUS_IS_EINVAL(s). -- justin
> Well, this is *us* generating the EINVAL by fiat, not getting it from
> some lower-down system call.
> Maybe we should still go with APR_EINVAL, on the principle of least
> surprise, though. I'm not sure; trusting people with more APR
> experience to know a good answer here.

Just for completeness. We should be returning APR_EINVAL, because that
is the safe code. However, on all platforms that implement EINVAL,
EINVAL and APR_EINVAL are equivalent. And, I can't think of any
platforms that don't define EINVAL.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 22 04:59:37 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.