[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Request For Review: commit-email.pl utf-8 support

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-07-22 00:59:07 CEST

Blair Zajac wrote:

>Karl Fogel wrote:
>>Does anyone know, would this patch to commit-email.pl do the Right
>>* tools/hook-scripts/commit-email.pl: Set UTF-8 charset and 8bit
>> transfer encoding on the outgoing mail.
>>Index: ./tools/hook-scripts/commit-email.pl
>>--- ./tools/hook-scripts/commit-email.pl
>>+++ ./tools/hook-scripts/commit-email.pl Fri Jul 19 19:29:51 2002
>>@@ -363,6 +363,8 @@
>> push(@head, "From: $mail_from\n");
>> push(@head, "Subject: $subject\n");
>> push(@head, "Reply-to: $reply_to\n") if $reply_to;
>>+ push(@head, "Content-Type: text/plain; charset=UTF-8\n");
>>+ push(@head, "Content-Transfer-Encoding: 8bit\n");
>> push(@head, "\n");
>> if ($sendmail =~ /\w/ and @email_addresses)
>Looks fine to me from a Perl point of view. I get email with those exact
>headers from Brane and there are no problems. His email has an extra
>"format=flowed" though,
>Content-Type: text/plain; charset=UTF-8; format=flowed

The format field just tells the MUA how paragraph boundaries are encoded
in the messate. <space><cr><lf> is a soft linebreak, <nonspace><cr><lf>
is a hard break/paragraph boundary. That's so that the MUA can reflow
the text correctly if the window is narrower than the text.

So, Karl, yes, your patch should be O.K.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 22 00:59:50 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.