Re: Request For Review: commit-email.pl utf-8 support

Karl Fogel wrote:
>
> Does anyone know, would this patch to commit-email.pl do the Right
> Thing?
>
> -K
>
> * tools/hook-scripts/commit-email.pl: Set UTF-8 charset and 8bit
> transfer encoding on the outgoing mail.
>
> Index: ./tools/hook-scripts/commit-email.pl
> ===================================================================
> --- ./tools/hook-scripts/commit-email.pl
> +++ ./tools/hook-scripts/commit-email.pl Fri Jul 19 19:29:51 2002
> @@ -363,6 +363,8 @@
> push(@head, "From: $mail_from\n");
> push(@head, "Subject: $subject\n");
> push(@head, "Reply-to: $reply_to\n") if $reply_to;
> + push(@head, "Content-Type: text/plain; charset=UTF-8\n");
> + push(@head, "Content-Transfer-Encoding: 8bit\n");
> push(@head, "\n");
>
> if ($sendmail =~ /\w/ and @email_addresses)

Looks fine to me from a Perl point of view. I get email with those exact
headers from Brane and there are no problems. His email has an extra
"format=flowed" though,

Content-Type: text/plain; charset=UTF-8; format=flowed

which doesn't appear to have any effect on the UTF-8 aspects of the
messages, judging from a Google search and RFC 2646, so we don't need it.

http://www.rfc-editor.org/rfc/rfc2646.txt

Best,
Blair

>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org