[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: gregames, are you sure about Makefile.in rev 1.122 ?

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-19 21:32:35 CEST

I wrote:
> 2002-07-19 10:11 gregames
>
> * Makefile.in (1.122): Install mime.types and magic in conf/ if
> they don't already exist.
>
> The patch is below. In the added code, it looks like perhaps the
> sense of the first `if' test is reversed, though that may be
> relatively harmless.

Whups, no, it's not harmless -- it is likely the cause of the problem.
That's the code that tries to guarantees that the confdir has been
created; and it's misdetecting whether or not the dir already exists.

Here's a tentative patch. I'm testing this right now, will report if
it fixes the problem for me:

   2002-07-19 15:06 <kfogel@collab.net>

        * Makefile.in (install-conf): Fix sense of test for confdir.

Index: Makefile.in
===================================================================
RCS file: /home/cvspublic/httpd-2.0/Makefile.in,v
retrieving revision 1.124
diff -u -r1.124 Makefile.in
--- Makefile.in 19 Jul 2002 15:32:36 -0000 1.124
+++ Makefile.in 19 Jul 2002 19:41:49 -0000
@@ -28,7 +28,7 @@
 
 install-conf:
         @echo Installing configuration files ; \
- if [ -d $(DESTDIR)$(sysconfdir) ]; then \
+ if [ ! -d $(DESTDIR)$(sysconfdir) ]; then \
             $(MKINSTALLDIRS) $(DESTDIR)$(sysconfdir) ; \
         fi ; \
         cd $(top_srcdir)/docs/conf; \

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 19 21:44:50 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.