Re: [PATCH] Issue #763

On Mon, Jul 15, 2002 at 02:49:06PM -0500, Karl Fogel wrote:
> The bug described in issue #763 is a core dump. If this patch
> "improves" the situation, it does so only by papering over some much
> deeper problem, by hiding post-commit failures entirely. Silent
> failure doesn't sound better than a core dump.

FWIW, Subversion stopped dumping core and requiring a db_recover
sometime between 2490 and 2521. Part of the "nasty commit bug" sounded
suspiciously close to my ear. Now, it does this:

    svn_error: #21086 : <A repository hook failed.>
      Commit failed (details follow):

    svn_error: #21086 : <A repository hook failed.>
      run_post_commit_hook: error running cmd
      `/home/slamb/test_repos/hooks/post-commit'

    svn_error: #21089 : <Error calling external program>
      svn_io_run_cmd: error exitcode 255 for process
      /home/slamb/test_repos/hooks/post-commit

And leaves the working copy as if the commit never happened. The patch
leaves the working copy correct; it just doesn't warn that post-commit
failed.

-- 
Scott Lamb
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org