Greg Stein <gstein@lyra.org> writes:
> Fine. Then apply it, and do some more work later. The simple fact is that
> this patch *does* improve the state of the system. We have the time, so it
> should be applied.
Are you sure it's an unambiguous improvement?
The bug described in issue #763 is a core dump. If this patch
"improves" the situation, it does so only by papering over some much
deeper problem, by hiding post-commit failures entirely. Silent
failure doesn't sound better than a core dump.
I don't think this is an improvement, but readily admit I've given
this about 5 minutes of thought. If there's a good reason to check
this in, let's hear it; I'm just not seeing it right now. (?)
-K
> On Mon, Jul 15, 2002 at 11:27:03AM -0500, Karl Fogel wrote:
> > Justin, just FYI:
> >
> > Since some more thought about how to handle post-commit hook errors is
> > probably needed, we should defer this patch until after Alpha. So
> > that's why the deafening silence right now :-). (The patch is not
> > incorrect, just doesn't go as far as it could, as you pointed out
> > yourself.)
> >
> > -K
> >
> > Justin Erenkrantz <jerenkrantz@apache.org> writes:
> > > This patch fixes Issue #763, BUT it doesn't print out the error
> > > message. What would be nice is if the error message were still
> > > printed, but the error wasn't treated as fatal.
> > >
> > > Another potential solution would be to have run_post_commit_hook
> > > error a certain code that callers to svn_repos_fs_commit_txn would
> > > know that the commit succeded, but post-commit failed. -- justin
> > >
> > > * subversion/libsvn_repos/hooks.c:
> > > (svn_repos_fs_commit_txn): Do not wrap run_post_commit_hook around
> > > SVN_ERR, so that post-commit errors are not treated as fatal.
> > >
> > > Index: ./subversion/libsvn_repos/hooks.c
> > > ===================================================================
> > > --- ./subversion/libsvn_repos/hooks.c
> > > +++ ./subversion/libsvn_repos/hooks.c 2002-07-12 21:12:41.000000000 -0700
> > > @@ -200,7 +200,7 @@
> > > SVN_ERR (svn_fs_commit_txn (conflict_p, new_rev, txn));
> > >
> > > /* Run post-commit hooks. */
> > > - SVN_ERR (run_post_commit_hook (repos, *new_rev, pool));
> > > + run_post_commit_hook (repos, *new_rev, pool);
> > >
> > > return SVN_NO_ERROR;
> > > }
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> > > For additional commands, e-mail: dev-help@subversion.tigris.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> > For additional commands, e-mail: dev-help@subversion.tigris.org
>
> --
> Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 15 22:02:02 2002