=?ISO-8859-1?Q?F=E9liciano?= Matias <feliciano.matias@free.fr> writes:
> > Le sam 13/07/2002 à 11:23, Féliciano Matias a écrit :
> >
> > I reply to me.
> > > CONCLUSION :
> > > ============
> > >
> > > "svnadmin dump" seems bogus :
> > > - "svnadmin dump" add an useless content when a node indicate only a
> > > renaming file and this content is wrong.
> > > - when a node indicate only a renamaing file, "svnadmin dump" try to
> > > change the content of the node but indicate "Node-action: add".
> >
> > this two points are only for a binary file (perhaps for all files that
> > have a property hash not empty).
> >
> > > - "svnadmin dump" forget the "real" content when only the property hash
> > > is change or when the content has not changed (renaming file).
> > >
> > > personally, the dump format need to set "property hash" and "real
> > > content" independe and it shoud be good to extend "Node-action" for a
> > > better legibility.
> > >
> > >
>
> It's me again.
>
> I do a small fix in subversion/libsvn_repos/dump.c :
>
> --- subversion-0.13.2.orig/subversion/libsvn_repos/dump.c Sat Jul 13
> 18:44:13 2002
> +++ subversion-0.13.2/subversion/libsvn_repos/dump.c Sat Jul 13 18:59:36
> 2002
> @@ -341,6 +341,13 @@
> return SVN_NO_ERROR;
> }
>
> + /* currently, the format dump does not permit to dump either the props
> + * or the text. We need to do both. */
> + if (must_dump_props || must_dump_text) {
> + must_dump_props = TRUE ;
> + must_dump_text = TRUE ;
> + }
> +
> /* Start prepping content to dump... */
>
> /* If the node either has no props, or we're not supposed to dump
>
>
> It is not THE solution. This only resolve the fellowing problems :
It is not THE solution, and it is not even accurate, unfortunately.
The dumper was designed so that if the "text" of a copied file did not
change, that text was not dumped. First, it doesn't *need* to be
dumped because the loader gets it for free when *it* does the copy
again at load time. Secondly, it leaves us unable to easily ask of
the new loaded repository, "Did the text of this file change?" because
all such files will look (initially) as though they have textual mods.
I believe this bug to be one in the loader, not the dumper, and am
investigating it as such right now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 15 21:13:55 2002