[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: nasty commit bug

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-07-12 20:20:59 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> Pilchie had to run off for a bit, but he's discovered some kind of
> nasty bug:
> 1. his commit segfaulted in post-commit processing

What was the command line? What targets were given?

> 2. he managed to commit a garbaged props.c file. (even though we
> have a checksum!)
> These two problems may or may not be related. But before he vanished
> from IRC, he printed a backtrace in gdb that indicated that problem #1
> probably has something to do with the new libsvn_wc batons:
> <pilchie> #0 0x0806c00d in svn_wc_adm_write_check (adm_access=0x0)
> <pilchie> at ../svn.source/subversion/libsvn_wc/lock.c:135
> <pilchie> #1 0x080640ac in svn_wc_process_committed (
> <pilchie> path=0x80e0448 "/home/kevin/projects/svn.source/subversion/clients/cmdline/main.c", adm_access=0x0, recurse=0, new_revnum=2489,
> <pilchie> rev_date=0x8117148 "2002-07-12T16:32:04.893379Z",
> <pilchie> rev_author=0x8117168 "kevin", pool=0x81119e0)

OK, it looks like the hash lookup has returned NULL, that should not
happen. However the commit has already been sent to the server so I
don't think this can be responsible for the corruption.

> <pilchie> at ../svn.source/subversion/libsvn_wc/adm_ops.c:202
> <sussman> oh NO
> <pilchie> #2 0x08055711 in svn_client_commit (commit_info=0xbffff8e8,
> <pilchie> notify_func=0x804d190 <notify>, notify_baton=0x80e39e0,
> <pilchie> auth_baton=0x80e36c0, targets=0x80e3650,
> <pilchie> log_msg_func=0x805314c <svn_cl__get_log_message>, log_msg_baton=0x80e39f8,
> <sussman> you committed garbage!
> <pilchie> xml_dst=0x0, revision=-1, nonrecursive=0, pool=0x80db8a0)
> <sussman> look at the log message!
> <pilchie> at ../svn.source/subversion/libsvn_client/commit.c:928
> <pilchie> #3 0x0804c791 in svn_cl__commit (os=0x80dba00, opt_state=0xbffffa10,
> <pilchie> pool=0x80db8a0) at ../svn.source/subversion/clients/cmdline/commit-cmd.c:91
> <pilchie> #4 0x0805010d in main (argc=6, argv=0xbffffaf4)
> <pilchie> at ../svn.source/subversion/clients/cmdline/main.c:1229
> <pilchie> WTF

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 12 20:21:28 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.