[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Problem with svn_wc_process_committed

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-07-12 20:16:34 CEST

Justin Erenkrantz <jerenkrantz@apache.org> writes:

> On Fri, Jul 12, 2002 at 11:40:44AM +0100, Philip Martin wrote:
> > Does your cacheing patch change the locking in some way? I don't see
> > a test failure with unmodified r2478.
> harvest_committables will lock the children as it descends down
> the tree. Since it doesn't unlock, when it exits, it still holds
> onto the lock (and is stored in *locked_dirs).
> svn_wc_process_committed will then attempt to re-acquire a lock we
> already have.

But svn_path_condense_targets is called before harvest_committables
and that is supposed to remove the ancestor/descendant relationship.

> > svn_wc_process_committed only locks children so the failure you are
> > seeing appears to imply that commit is trying to commit items that are
> > in an ancestor-child relationship. I though the commit processing
> > stripped out the children in this case, prior to taking out locks.
> Yes, that is what commit test #8 does. I don't believe the commit
> processing strips out children. -- justin

I'm still confused, as it doesn't fail when I run the test.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 12 20:17:04 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.