Re: svn commit: rev 2470 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

On Thu, Jul 11, 2002 at 02:02:19PM -0700, Justin Erenkrantz wrote:
>...
> Even if it is seventy calls to svn_wc_entry, each one of those
> functions has to be rewritten to accept the baton, create new

s/baton/context/ :-)

> batons when we go to subdirs, and then we have to propogate the
> baton down to those functions. (Look at the props_modified
> functions in my patch - even though they don't read the entries
> themselves - one of its helper functions does, so the baton has
> to be passed through there.) This is a real big house of cards.
> All of that said, yes, I'll still try to tackle this... -- justin

But the neat part is that it is pretty decomposible. You can slowly begin
pushing the context structure throughout the codebase (e.g. change one
function and its callers at a time), even if you aren't using it yet. At
some point, svn_wc_entry() will change, and you'll have the context ready.

As an interim change, you might even want a public function to extract the
path from the context so that you can more easily s/path/context/ in the
params, yet not lose the path that used to be passed (and is still needed
within the function).

That said, my gut feeling is kind of with Justin. Each of those entries_read
calls probably needs some new semantics around it. The changes are probably
all straight-forward, but there is just a "lot" of them.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org