Re: svn commit: rev 2470 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

On Thu, Jul 11, 2002 at 09:49:28PM +0100, Philip Martin wrote:
> I'd prefer to see it done correctly rather than hacked in a hurry.
> There is no immediate deadline, this doesn't have to happen for alpha.

Right.

> Is the task really that daunting? Don't overestimate its size, there
> are about thirty calls to svn_wc_entries, maybe seventy calls to
> svn_wc_entry.

Well, my time to hack on SVN is limited (although I've been doing
more SVN tasks at the expense of httpd/APR lately), so what I can
do isn't all that great.

Even if it is seventy calls to svn_wc_entry, each one of those
functions has to be rewritten to accept the baton, create new
batons when we go to subdirs, and then we have to propogate the
baton down to those functions. (Look at the props_modified
functions in my patch - even though they don't read the entries
themselves - one of its helper functions does, so the baton has
to be passed through there.) This is a real big house of cards.
All of that said, yes, I'll still try to tackle this... -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 11 23:02:52 2002