[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow revert --recursive to have implict dot-target

From: Ben Collins <bcollins_at_debian.org>
Date: 2002-07-10 22:41:15 CEST

On Wed, Jul 10, 2002 at 09:31:06PM +0100, Philip Martin wrote:
> Justin Erenkrantz <jerenkrantz@apache.org> writes:
>
> > + "usage: revert TARGET1 [TARGET2 [TARGET3 ... ]]\n"
> > + " Unless --recursive is passed, revert does not have an implicit\n"
> > + " target. Therefore, you must explicitly specify any targets\n"
> > + " (such as `.').\n\n"
>
> We try to protect the user against "svn revert" errors but allow the
> more destructive "svn revert --recursive" to run unhindered. I don't
> understand the logic behind this behaviour.

IMO, the more logical idea behind not having an implicit target with
"svn revert" is that it is not recursive by default. Which means an
implicit dot-target would simply revert the current wc directory. That's
usually not what the user wants.

However, if I take the time to do "svn revert --recursive", then It
should be reasonable to imply that I want to revert everything starting
at ".".

The original idea to protect the user is to not have implicit recursive.
That keeps bad things from happening. Having an implicit dot-target with
recursive enabled manually, is completely sane, and safe. The user
obviously knows what they want in that case.

Ben

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://linux1394.sourceforge.net/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 10 22:54:10 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.