RE: proposal to add apr_check_dir_empty() to APR

> > Also, APR_EGENERAL seems a bit vague, how about APR_EEXISTS?
>
> We should either make a new status code explicitly for this, or return
> via an int* parameter. Personally I think the int* solution is
> cleaner: the function should return an error status iff something went
> wrong, and use an entirely separate channel for returning the answer.
>
> Would anyone object to this solution?

Yes, I do. The whole point of the apr_status_t is to allow for both
error codes and status codes. Use them. We use status codes throughout
APR to signify that there is important information that is neither
success nor failure. Take a look at apr_proc_wait for just one example.

Ryan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 23:17:45 2002