[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2386 - trunk/subversion/libsvn_fs

From: <cmpilato_at_collab.net>
Date: 2002-07-02 17:11:05 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> > This function is listed in include/svn_fs.h under the topic "Files",
> > and has the word "contents" in its name. Files have contents.
> > Directories do not (in filesystem speak, they have "entries"; the
> > generic term for the stuff in files and dirs is "data"). The use of
> > svn_fs__things_different under the hood is an implementation detail
> > unrelated to the promises made by, and the semantic use of, the
> > svn_fs_contents_changed function.
> Directories don't have "contents"? Entries aren't contents?

In terms of the filesystem's function naming scheme, no. Directories
and file both have "data". For files, we call this the file's
"contents", for directories, we call this the file's "entries".
However, a quick look through svn_fs.h shows that perhaps this isn't
consistently enforced in other comments and such. My apologies.

> > Please revert this change, and change your calling code to simply ask
> > the is-file() question.
> You're missing the spirit of the change. The dumper wants to pass
> any two nodes to svn_fs__things_different -- two dirs, two files,
> whatever. It wants to know if the data keys or prop keys are
> different.

No, no it doesn't. It wants to know if it needs to write out the full
*text* of a *file* that has been added with history -- that's it. It
knows *nothing* of data keys or prop keys, and cares nothing about
directories. I mean, what does the dumper now do if contents_changed
reports that a directory's entries list has changed? Nothing.
Nothing at all.

You already have a the `kind' variable populate, just use the thing.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 17:12:15 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.