[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2386 - trunk/subversion/libsvn_fs

From: <cmpilato_at_collab.net>
Date: 2002-07-02 16:34:17 CEST

sussman@tigris.org writes:

> Author: sussman
> Date: Mon, 01 Jul 2002 17:03:30 -0500
> New Revision: 2386
> Modified:
> trunk/subversion/libsvn_fs/tree.c
> Log:
> Fix bug #776:
> Let the dumper call svn_fs_contents_changed() on any two nodes.
> * libsvn_fs/tree.c (svn_fs_contents_changed): remove the artifical
> restriction requiring that we compare two files.
> svn_fs__things_different() certainly doesn't care; it's just
> comparing data-keys and prop-keys. Heck, we could compare a file
> against a dir if we wanted!

This function is listed in include/svn_fs.h under the topic "Files",
and has the word "contents" in its name. Files have contents.
Directories do not (in filesystem speak, they have "entries"; the
generic term for the stuff in files and dirs is "data"). The use of
svn_fs__things_different under the hood is an implementation detail
unrelated to the promises made by, and the semantic use of, the
svn_fs_contents_changed function.

Please revert this change, and change your calling code to simply ask
the is-file() question.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 16:35:13 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.