[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: commit_email.pl improvements

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-07-02 02:32:00 CEST

Blair Zajac wrote:

>Several things I want to do with commit_email.pl. Feedback needed.
>1) I have a svn tree with 6 different projects in it. I only
> want mods to specific portions of the tree emailed to specific
> mailing lists. So I'm thinking to add a table with two
> columns, the first is a regular expression to match against
> a path and the second is the email address. If any of the
> modified paths match the regular expression, then that email
> address gets sent the log.

That's a nice idea, but I don't think it makes sense to stop at the
emails. IMHO all the options should be per-project, if you go this way.

> The question is, where to create the table. Should it be
> a list of command line arguments, something like

Just teach the script to read options from a file, and let the options
and mail addresses be intermingled, with each mail address using the
options that preceded it. Then you could have:

commit-email.pl repos rev \
  -m '^/proj1/' -r fred@here -l proj1.log proj1@here \
  -m '^/proj2/' -l proj2.log proj2@here boss@here \
  -m '^/' -l toplevel.log only.me@here

> Two other solutions are to hardwire the table in the script
> itself, but this is a pain when anybody updates the script
> (do you own diff and patch your own script) or to create a
> configuration file for the script and load in the list from
> there (cleaner, but yet another file to set up).

If you expect long command lines, you have to allow parameters to be
passed in files.

>2) commit_email.pl doesn't handle renames really nicely. Right
> now they look like this:
> Author: blair
> Date: Fri, 28 Jun 2002 22:13:56 -0700
> New Revision: 128
> Added:
> trunk/orca/packages/Digest-MD5-2.16/
> trunk/orca/packages/Storable-1.0.13/
> Removed:
> trunk/orca/packages/Digest-MD5-2.13/
> trunk/orca/packages/Storable-1.0.11/
> Log:
> To prepare to load orca-0.27b2 into trunk/orca, perform 2 renames.
> * trunk/orca/packages/Digest-MD5-2.16: Renamed from
> trunk/orca/packages/Digest-MD5-2.13.
> * trunk/orca/packages/Storable-1.0.13: Renamed from
> trunk/orca/packages/Storable-1.0.11.
> Copied: Digest-MD5-2.16 (from rev 127, trunk/orca/packages/Digest-MD5-2.13)
> Copied: Storable-1.0.13 (from rev 127, trunk/orca/packages/Storable-1.0.11)
> It would be great if adds and deletes could be matched up.
> This would be a lot easier if the Copied message that
> 'svnlook diff' prints would print the complete path to the new
> name.
> Does anybody mind if the first path name was changed? It
> would make matching up named much easier.

Wouldn't it be better to have a Moved: section before the log message,
just like the Added, Removed and Modified sections? That would make
things nice and consistent.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 02:32:30 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.