Question for Brane:
Your commit of 2359 fixed all our build problems for the new Windows
configuration file stuff. Did you by any chance test whether the new
code actually works? If you put `Subversion\proxies' in the
appropriate places, with live data, does it have the expected effects?
I can't test it here right now, because Mike Pilato's VC++6.0 doesn't
have a recent enough platform SDK, and Mike's at home sleeping off
last night's coding binge. But it would be great to close issue #579
(and start on #668 finally!) if you have confirmed that the new code
works.
(Question directed at Brane, since he committed 2359, but also at
anyone else with a Windows dev environment and some spare time to
test.)
Thanks,
-Karl
> rev 2359: brane | Thu, 27 Jun 2002 19:49:04 -0500 | 15 lines
>
> Work on issue #579, basically fixing what Karl and Mike broke. :-)
>
> * libsvn_subr/config_impl.h (svn_config__win_config_path): Declare.
> * libsvn_subr/config_win.c: Include <shlobj.h> before any APR headers,
> to avoid compiler errors because of include file weirdness.
> (svn_config__win_config_path): New; wrapper around SHGetFolderPathA.
>
> * libsvn_subr/config_file.c: Don't include <shlobj.h>.
> (svn_config__sys_config_path, svn_config__user_config_path): Use
> svn_config__win_config_path on Win32.
>
> * libsvn_subr/libsvn_subr.dsp: Include shell32.lib in the library.
>
> * INSTALL: Warn about needing a recent Platform SDK to build on Windows.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 28 19:40:35 2002