[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2196 - trunk/subversion/svnadmin

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-06-14 00:03:28 CEST

Greg Stein wrote:

>On Thu, Jun 13, 2002 at 04:34:47PM -0500, brane@tigris.org wrote:
>>Author: brane
>>Date: 2002-06-13 21:34 GMT
>>New Revision: 2196
>> trunk/subversion/svnadmin/main.c
>>Fix compiler error on Windows.
>>* svnadmin/main.c (create_stdio_stream): APR_DECLARE the open-file
>>callback. This macro is not a no-op on Windows, and without this change,
>>the compiler compains about different function attributes (probably has
>>to do with the calling convention).
>Yep -- calling conventions. The exported APR functions are __stdcall (which,
>I believe, means Pascal-style conventions). And I'm guessing that our .dsp
>files set cdecl as the default convention.
Our .dsp files set nothing, we just use whatever is the compiler default.
I don't think we need something like APR_DECLARE for Subversion, do we?

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 14 00:04:03 2002

This is an archived mail posted to the Subversion Dev mailing list.