Re: svn commit: rev 2162 - trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline/getopt_tests_data

On Wed, Jun 12, 2002 at 07:17:09PM +0200, Sander Striker wrote:
> > From: Garrett Rooney [mailto:rooneg@electricjellyfish.net]
> > Sent: 12 June 2002 18:59
> > On Wed, Jun 12, 2002 at 05:53:06PM +0100, Philip Martin wrote:
> >
> >> I see, the problem is one of expectation.
> >>
> >> I expected 'svn rollback -r 5 bar' to undo all the changes between
> >> revisions CURRENT and 5. What it does is to undo the change between
> >> revisions 5 and 4.
> >
> > right now, we just revert the actual revision you give us.
>
> Ah. I must admit that I also expected 'svn rollback -r 5 bar' to
> mean what Philip thought.

i figured that one could easily script that behavior, and that this
would let one easily revert a selected revision, which seems like it
would be nice to have. on the other hand, i can see how it would be
nice to be able to say 'roll back to revision x', but i'm not sure how
to provide both behaviors and have the command be simple and hard to
get wrong.

> And I wonder if it is a good idea to allow 'svn rollback' to
> mean revert all changes between CURRENT and CURRENT - 1.

i'd be ok with that, but how do we deal with mixed revision working
copies? 'svn rollback foo bar' where foo is at revision 5 and bar is
at revision 6... do we roll foo to 4 and bar to 5?

> > i was also considering the possibility of interpreting 'svn rollback
> > -r 10:15' to mean 'revert revisions 10, 11, 12, 13, 14, and 15'. what
> > do people think of that?
>
> I'm not keen on having different meanings for the same option.

yeah, i would like to keep the syntax for this command as simple as
possible, which is why i went with just the single '-r rev'.

-garrett

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org