[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2115 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client trunk/subversion/tests/clients/cmdline

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-06-07 22:11:59 CEST

> > + if (hash_b)
> > + for (hi = apr_hash_first (pool, hash_b); hi; hi = apr_hash_next (hi))
> > + {
> > + const void *key;
> > + apr_ssize_t klen;
> > +
> > + apr_hash_this (hi, &key, &klen, NULL);
> > +
> > + if (! (hash_a && apr_hash_get (hash_a, key, klen)))
> > + SVN_ERR ((*diff_func) (key, klen, svn_hash_diff_key_b,
> > + diff_func_baton));
> > + }
>
> The condition should be: if (hash_b != NULL && hash_a != NULL)
>
> The code block does nothing if hash_a is NULL, so no reason to iterate over
> hash_b.

Which condition (the first `if', or the second)?

I'm not sure I understand what you mean. (Did you misread the first
`if' above as hash_a instead of hash_b?)

The section above invokes the diff_func on those keys of hash_b which
were not already done as part of hash_a.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 7 22:16:59 2002

This is an archived mail posted to the Subversion Dev mailing list.