Re: svn commit: rev 2115 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client trunk/subversion/tests/clients/cmdline

On Fri, Jun 07, 2002 at 02:38:34PM -0500, kfogel@tigris.org wrote:
> Author: kfogel
> Date: 2002-06-07 19:38 GMT
> New Revision: 2115
>
> Added:
> trunk/subversion/tests/clients/cmdline/module_tests.py

See: http://www.python.org/peps/pep-0008.html

In particular:
 - Immediately before the open parenthesis that starts the argument
   list of a function call, as in "spam (1)". Always write
   this as "spam(1)".

The Python code should look like Python code -- no spaces before parens.

>...
> +++ trunk/subversion/libsvn_subr/hash.c Fri Jun 7 14:38:28 2002
>...
> + if (hash_b)
> + for (hi = apr_hash_first (pool, hash_b); hi; hi = apr_hash_next (hi))
> + {
> + const void *key;
> + apr_ssize_t klen;
> +
> + apr_hash_this (hi, &key, &klen, NULL);
> +
> + if (! (hash_a && apr_hash_get (hash_a, key, klen)))
> + SVN_ERR ((*diff_func) (key, klen, svn_hash_diff_key_b,
> + diff_func_baton));
> + }

The condition should be: if (hash_b != NULL && hash_a != NULL)

The code block does nothing if hash_a is NULL, so no reason to iterate over
hash_b.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org