Re: svn commit: rev 2111 - trunk/subversion/svnadmin

On Fri, Jun 07, 2002 at 11:05:34AM -0500, sussman@tigris.org wrote:
> Author: sussman
> Date: 2002-06-07 16:05 GMT
> New Revision: 2111
>
> Modified:
> trunk/subversion/svnadmin/main.c
> Log:
>
> Make 'svnadmin deltify' much more efficient.
> Patch from Mike Pilato <cmpilato@collab.net>
>
> * svnadmin/main.c (do_deltify_undeltify, deltify_undeltify): don't
> pass the recursive flag to svn_fs_undeltify anymore; instead, do the
> undeltifying recursion *outside* of BerkeleyDB.

I disagree with the sense of this change. Why isn't svn_fs_undeltify()
*itself* fixed to solve its problems?

And you don't describe what is "inefficient" about the function. The number
of locks it uses? The time or memory performance?

Effectively, this change is saying "oh, gee. the function is broken when you
use recursion. well, let's leave the broken function and just not use that
feature."

To that end, -1 on this commit. You're papering over a problem rather than
solving it.

[ which can be solved in two ways: solve the true underlying problem (but I
  don't know what that is since it wasn't stated), or move this recursion
  code into svn_fs_deltify(). ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org