praise valgrind!

Philip, that last commit of yours (fixing the fs memleak found by
valgrind) just saved our butts, big-time.

Cmpilato and I have been hunting a memory leak all afternoon together.

  * Using the "old" fs schema (r2092), my loading of 1000 revisions
    from a dumpfile would go up to 50 megs of RAM, and just sort of
    bobble up-and-down until finished.

  * Using the "new" fs schema (r2093), the same test grew unboundedly,
    to 200M and beyond. Totally unusable.

So cmpilato and I have been studying pool-debug logs (ugh) and walking
through the dumpfile parser code ("it's tight! TIGHT code!", we'd
scream at one another.) We were totally stumped.

Then the valgrind commit came through.

Now this test use 12 megs of memory, period, never grows beyond that.

At last, I think we're ready to a dump & load of our real repository.

   Excitedly,

     Ben C-S, Church of Valgrind.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 6 22:20:17 2002