Re: svn commit: rev 2103 - trunk/subversion/libsvn_client

Greg Stein <gstein@lyra.org> writes:
> (unrelated to your change, but I see it in the context...)
>
> Seems like the item should probably be a pcalloc to ensure that the revision
> structure is zeroed. Is that important? or is setting the kind to HEAD
> enough to make code agnostic to the (non-zero) other fields.

It's enough -- once we know it's of kind `head', the value portion is
ignored.

> >...
> > @@ -172,7 +167,7 @@
> > auth_baton,
> > item->url,
> > svn_path_join (path, item->target_dir, pool),
> > - item->revision,
> > + &(item.revision),
>
> Euh... that isn't going to compile :-)

Looks like I got protected by an #if 0 or something :-). Fixed now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 6 21:36:41 2002