Re: svn commit: rev 2103 - trunk/subversion/libsvn_client

On Thu, Jun 06, 2002 at 11:19:50AM -0500, kfogel@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_client/externals.c Thu Jun 6 11:19:33 2002
>...
> @@ -97,7 +94,6 @@
> target_dir = APR_ARRAY_IDX (line_parts, 0, const char *);
> url = APR_ARRAY_IDX (line_parts, 1, const char *);
> item = apr_palloc (pool, sizeof (*item));
> - revision = apr_palloc (pool, sizeof (*revision));

(unrelated to your change, but I see it in the context...)

Seems like the item should probably be a pcalloc to ensure that the revision
structure is zeroed. Is that important? or is setting the kind to HEAD
enough to make code agnostic to the (non-zero) other fields.

>...
> @@ -172,7 +167,7 @@
> auth_baton,
> item->url,
> svn_path_join (path, item->target_dir, pool),
> - item->revision,
> + &(item.revision),

Euh... that isn't going to compile :-)

How about: &item->revision

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org