[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

to brane about Windows builds

From: Nuutti Kotivuori <naked_at_iki.fi>
Date: 2002-06-04 06:22:09 CEST

,----[ #svn ]
| 01:42 brane:#svn => time-test is failing on Windows
| 01:42 brane:#svn => looks like an apr error again
| 01:43 brane:#svn => in this case, gmt_offset doesn't get adjusted
| for DST
| 01:44 brane:#svn => gmt_offset should be the offset of the
| timezone, not the local ime.
| 01:45 brane:#svn => so the time test (using the old format, which
| is in local time) is off by 1 hour
`----

Yes, I left that old format there intentionally to be in local time
just to catch regression of that timezone handling.

But, if only the old format time test fails - and the time read-write
invariant works - it's not so bad. The timestamp generated after my
patch (rev 2012) are not in local time anymore - and apparently apr
seems to work fine for timestamps that are not in local time.

So, it hasn't affected us for a while now (except for possible user
display in some places) - and the old timestamps are already broken -
so nothing else breaks if that is fixed.

...

Perhaps there should be a troubleshooting guide which would list
possible places to look when a regression test fails?

time-test, #1) APR is borked again.

time-test, #2) APR is borked again.

...

:)

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 4 06:24:06 2002

This is an archived mail posted to the Subversion Dev mailing list.