[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Maintaining NodeID sanity

From: Glenn A. Thompson <gthompson_at_cdr.net>
Date: 2002-05-10 17:02:26 CEST

Hey:

This whole thread has been really educational for me. Thanks to all who contributed
to it.

> > Seriously, who cares? With the exception of the revisions, these
> > things are never anything bat const char * values, so they can be whatever
> > we want (as long as we can definitively answer the is-greater-than
> > question). Whatever, I'm not personally sold on either way.
>
> I care. My point is: why obscure the integers with a base64 encoding?
>
> If you do, then you need the comments. If you leave them as plain integers,
> then you don't need them :-)
>
> Yes, they can be arbitrary strings, but why? "Just because we can, doesn't
> mean we should."
>

I agree with gstein here. The concepts in this code are tough enough (for feebs
like myself) without obfuscated integers.

gat

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 10 16:59:19 2002

This is an archived mail posted to the Subversion Dev mailing list.