[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Maintaining NodeID sanity

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-05-10 10:39:33 CEST

On Thu, May 09, 2002 at 08:49:44PM -0500, cmpilato@collab.net wrote:
> Greg Stein <gstein@lyra.org> writes:
>
> > Why? Why convert them to base64? Why not keep them *all* as integers? You're
> > working with integers, so keep them that way; otherwise, people will wonder
> > WTF those weird character sequence are, go to dig, and then go "oh. that's
> > it? just integers. damn them for wasting my time."
>
> Oh that's right, you're the guy that doesn't believe in using inline
> comments in the code ... ;-)
>
> Seriously, who cares? With the exception of the revisions, these
> things are never anything bat const char * values, so they can be whatever
> we want (as long as we can definitively answer the is-greater-than
> question). Whatever, I'm not personally sold on either way.

I care. My point is: why obscure the integers with a base64 encoding?

If you do, then you need the comments. If you leave them as plain integers,
then you don't need them :-)

Yes, they can be arbitrary strings, but why? "Just because we can, doesn't
mean we should."

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 10 10:38:18 2002

This is an archived mail posted to the Subversion Dev mailing list.