Re: Reminder: $EDITOR with spaces?

On Sun, 28 Apr 2002, Zack Weinberg wrote:

> -0: I don't see what's wrong with just calling system() in this case, like
> everyone else who handles $EDITOR.

Because using system() for this was discussed and turned down when I first
started messing with $EDITOR support, back in January:

[ said regarding using svn_io_run_cmd() instead of system() ]
<quote>
It's not just a "better option" but a requirement :-) system() isn't
portable, and it isn't exactly the safest function in the world. Granted,
this is all client stuff, but I'd still not like to see system-based
exploits in the code.
</quote>
http://subversion.tigris.org/servlets/ReadMsg?msgId=55026&listName=dev

Of course, matters and opinions change. This may not be valid anymore...

-- 
      Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org