[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] $EDITOR with spaces

From: Marcus Comstedt <marcus_at_mc.pp.se>
Date: 2002-04-18 16:10:06 CEST

Daniel Stenberg <daniel@haxx.se> writes:

> The reasons for not using system() still remain the same ones as before I
> take it.

And those are? Since you're going to launch an arbitrary
binary/script anyway, security problems are harly the issue here.
What else?

> One other benefit of doing the unescaping ourselves, would be that it would
> not depend on your system or on your shell or whatever, but we could document
> it and it would work the same on all platforms svn runs on...

Not really as useful as it sounds. Setting $EDITOR to
"C:\WINDOWS\SYSTEM32\NOTEPAD.EXE" is unlikely to work on anything
other than Windows anyway, etc. Respecting the OS specific quoting
mechanism could rather be seen as an advantage.

  // Marcus

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 18 16:13:30 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.